Request for Review: Deterministic Sorting Fix in auto_control_deps_utils.py (PR #110822)

TensorFlow
,
1

Hello TensorFlow Community,

I am reaching out to request a maintainer review for Pull Request #110822, which addresses a non-deterministic resource categorization issue within the core framework.

Link to PR: https://github.com/tensorflow/tensorflow/pull/110822

Summary of Changes:

  • Logical Fix: Implemented explicit sorting for _read_only_resource_inputs attributes in auto_control_deps_utils.py to ensure consistent execution behavior regardless of the backend’s provided index order.

  • Verification: Added a comprehensive unit test in auto_control_deps_test.py that specifically validates sorted index retrieval.

  • Current Status: All CI/CD checks are passing (Green), and the Contributor License Agreement (CLA) is signed and verified.

The Bottleneck: The previously assigned reviewer, @mihaimaruseac, has kindly informed me that they are no longer with Google and cannot finalize the approval.

I am looking for a new reviewer (ideally from SIG-Build or anyone familiar with auto_control_deps logic) to take a final look at the implementation. I have already addressed minor feedback regarding PyLint 80-char limits and expanded the test coverage.

Thank you for your time and for the incredible work on the TensorFlow ecosystem.

Best regards,

Muhammad Husnain

Computer Science Student & Open Source Contributor

2

Hi @M_Husnain ,
A new reviewer has been assigned, and the PR is currently under review. Thank you for contributing a fix to TensorFlow; we really appreciate the effort.

3

Hi @Divya_Sree_Kayyuri, thank you again for assigning a new reviewer. I’m just following up as the PR has been updated with the final fixes and all tests are passing. Looking forward to the final feedback whenever the reviewer has a moment.